Improving client setup #1
Conversation
…e environment later
…C core method. Using hash based routing
…date-electron-app is only supporting those
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…ng URLs that are not inside our whitelist
| } | ||
|
|
||
| setImmediate(() => { | ||
| shell.openExternal(url); |
Check notice
Code scanning / Electronegativity
Review the use of openExternal Note
| sandbox: true, // @see https://github.com/doyensec/electronegativity/wiki/SANDBOX_JS_CHECK | ||
| }; | ||
|
|
||
| const window = new BrowserWindow(options); |
Check warning
Code scanning / Electronegativity
Limit navigation flows to untrusted origins. Middle-click may cause Electron to open a link within a new window Warning
| sandbox: true, // @see https://github.com/doyensec/electronegativity/wiki/SANDBOX_JS_CHECK | ||
| }; | ||
|
|
||
| const window = new BrowserWindow(options); |
Check warning
Code scanning / Electronegativity
Review the use of the contextIsolation option Warning
| sandbox: true, // @see https://github.com/doyensec/electronegativity/wiki/SANDBOX_JS_CHECK | ||
| }; | ||
|
|
||
| const window = new BrowserWindow(options); |
Check warning
Code scanning / Electronegativity
Use sandbox for untrusted origins Warning
ToDos for dev and prod builds on all platforms: